https://github.com/cracklib/cracklib/commit/a77a392272df3677f71c68e81fcdad1bc722732e From a77a392272df3677f71c68e81fcdad1bc722732e Mon Sep 17 00:00:00 2001 From: Olivier Gayot Date: Thu, 30 Nov 2023 18:36:17 +0100 Subject: [PATCH] Fix test-suite so it can run with Python 3.12 The test suite still used the obsolete assertEquals() function which was a deprecated alias for assertEqual() (without the s) and got dropped from Python 3.12. Use the replacement instead so the test-suite can run with Python 3.12. Signed-off-by: Olivier Gayot --- a/python/test_cracklib.py +++ b/python/test_cracklib.py @@ -69,52 +69,52 @@ def test_simple(self): def test_simple_lower(self): for passwd in ['t' * i for i in range( cracklib.MIN_LENGTH - cracklib.LOW_CREDIT)]: - self.assertEquals( + self.assertEqual( 1, cracklib.simple(passwd), 'password {0} should be detected as too simple'.format( passwd)) - self.assertEquals(0, cracklib.simple( + self.assertEqual(0, cracklib.simple( 't' * (cracklib.MIN_LENGTH - cracklib.LOW_CREDIT))) def test_simple_upper(self): for passwd in ['T' * i for i in range( cracklib.MIN_LENGTH - cracklib.UP_CREDIT)]: - self.assertEquals( + self.assertEqual( 1, cracklib.simple(passwd), 'password {0} should be detected as too simple'.format( passwd)) - self.assertEquals(0, cracklib.simple( + self.assertEqual(0, cracklib.simple( 'T' * (cracklib.MIN_LENGTH - cracklib.UP_CREDIT))) def test_simple_digit(self): for passwd in ['1' * i for i in range( cracklib.MIN_LENGTH - cracklib.DIG_CREDIT)]: - self.assertEquals( + self.assertEqual( 1, cracklib.simple(passwd), 'password {0} should be detected as too simple'.format( passwd)) - self.assertEquals(0, cracklib.simple( + self.assertEqual(0, cracklib.simple( '1' * (cracklib.MIN_LENGTH - cracklib.DIG_CREDIT))) def test_simple_other(self): for passwd in ['#' * i for i in range( cracklib.MIN_LENGTH - cracklib.OTH_CREDIT)]: - self.assertEquals( + self.assertEqual( 1, cracklib.simple(passwd), 'password {0} should be detected as too simple'.format( passwd)) - self.assertEquals(0, cracklib.simple( + self.assertEqual(0, cracklib.simple( '#' * (cracklib.MIN_LENGTH - cracklib.OTH_CREDIT))) def test_simple_combinations(self): testset = '#a' * (cracklib.MIN_LENGTH // 2) for passwd in [testset[:i] for i in range( cracklib.MIN_LENGTH - cracklib.LOW_CREDIT - cracklib.OTH_CREDIT)]: - self.assertEquals( + self.assertEqual( 1, cracklib.simple(passwd), 'password {0} should be detected as too simple'.format( passwd)) - self.assertEquals(0, cracklib.simple( + self.assertEqual(0, cracklib.simple( testset[:(cracklib.MIN_LENGTH - cracklib.LOW_CREDIT - cracklib.OTH_CREDIT)]))